Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] fix compiler warning about types conversion in cpp tests #4418

Merged
merged 1 commit into from
Jun 29, 2021
Merged

[tests] fix compiler warning about types conversion in cpp tests #4418

merged 1 commit into from
Jun 29, 2021

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Jun 28, 2021 •
edited
Loading

LightGBM/include/LightGBM/utils/array_args.h

Line 101 in b918b5b

inline static void Partition(std::vector<VAL_T>* arr, int start, int end, int* l, int* r) { 

D:\a\1\s\tests\cpp_tests\test_array_args.cpp(21): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [D:\a\1\s\build\testlightgbm.vcxproj]
D:\a\1\s\tests\cpp_tests\test_array_args.cpp(31): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [D:\a\1\s\build\testlightgbm.vcxproj]
D:\a\1\s\tests\cpp_tests\test_array_args.cpp(38): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [D:\a\1\s\build\testlightgbm.vcxproj]
D:\a\1\s\tests\cpp_tests\test_array_args.cpp(47): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [D:\a\1\s\build\testlightgbm.vcxproj]

@StrikerRUS StrikerRUS marked this pull request as ready for review June 28, 2021 16:49
@StrikerRUS StrikerRUS requested a review from jameslamb June 28, 2021 16:49
jameslamb
jameslamb approved these changes Jun 29, 2021
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me!

I can see in the logs that this warning in the Windows cpp_tests job is resolved by this PR.

shiyu1994
shiyu1994 approved these changes Jun 29, 2021
View reviewed changes
Copy link
Collaborator

@shiyu1994 shiyu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@shiyu1994 shiyu1994 merged commit 189a801 into master Jun 29, 2021
@StrikerRUS StrikerRUS deleted the static_cast branch June 30, 2021 11:00
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shiyu1994 shiyu1994 shiyu1994 approved these changes

@jameslamb jameslamb jameslamb approved these changes

@btrotta btrotta Awaiting requested review from btrotta

@chivee chivee Awaiting requested review from chivee

@guolinke guolinke Awaiting requested review from guolinke guolinke is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StrikerRUS @jameslamb @shiyu1994